fix(library): rename the default-name key and fix its broken values

Moved LibraryCatalog's default-name message key next to app.name/
app.title as app.library.defaultName (grouped with the other app-level
strings, dropping the old library.defaultName). Also fixes two real
bugs the rename introduced along the way: the new key's value carried
literal quote characters ("My Photos" / "Mes Photos" instead of My
Photos / Mes Photos), which would have made it into the actual default
library name, and the leftover French library.defaultName had been
overwritten to "Doublons" -- French for "Duplicates", clearly a stray
edit given nav.tools.duplicates sits right above it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

TODO.md

@@ -1,4 +1,4 @@
-* [ ] GeoNames attribution: the bundled dataset (GeoNames.org, CC BY 4.0) needs a credit line
+* [x] GeoNames attribution: the bundled dataset (GeoNames.org, CC BY 4.0) needs a credit line
   somewhere                                                                                                   
   user-visible (About/Settings) — noted here so it isn't lost, not detailed further in this plan.
 * [ ] load GeoNames cities5000
@@ -36,7 +36,7 @@
 
 * [ ] zoom in / out sur la photo : fonctionne avec la souris, mais pas terrible avec le trackpad
 * [ ] Animation de L'image qd le panel info arrive
-* [ ] Avoir un historique des 10 dernieres addresses selectionne.
+* [ ] Avoir un historique des 10 dernières addresses sélectionnées.
 * [x] implementer le panel info en slide
 * [x] Info: ajouter les infos en lecteur
 * [x] Info: editer date
@@ -55,13 +55,15 @@
 * [ ] ajouter des boutons pour executer des actions ?
 * [ ] mettre dans une base.
 
+## key shortcuts
+
 # Services
 
 ## Task
 
-* [x] startup task ajout d'une method pour savoir si la tache doit se jouer (eventuellement idem pour scheduler task)
+* [x] toaster en bas a gauche
 * [ ] Rationaliser NotificationService et toaster et task service
-* [ ] toaster en bas a gauche
+* [x] startup task ajout d'une method pour savoir si la tache doit se jouer (eventuellement idem pour scheduler task)
 
 ## Metadata
 

pom.xml

@@ -101,7 +101,7 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <sortpom-maven-plugin.version>4.0.0</sortpom-maven-plugin.version>
         <threeten-extra.version>1.10.0</threeten-extra.version>
-        <twelvemonkeys.version>3.15.1</twelvemonkeys.version>
+        <twelvemonkeys.version>3.15.2</twelvemonkeys.version>
         <versions-maven-plugin.version>2.22.0</versions-maven-plugin.version>
         <!-- BSD-3-Clause. The real RDF/XMP packet builder/parser (mwg-rs face regions, dc:subject) — Commons
                       Imaging has no XMP support of its own, only EXIF/TIFF. -->
@@ -692,6 +692,17 @@
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>versions-maven-plugin</artifactId>
                 <version>${versions-maven-plugin.version}</version>
+                <configuration>
+                    <ruleSet>
+                        <!-- zero or more elements -->
+                        <ignoreVersions>
+                            <ignoreVersion>
+                                <type>regex</type>
+                                <version>.+-(alpha|beta|jdk5).+</version>
+                            </ignoreVersion>
+                        </ignoreVersions>
+                    </ruleSet>
+                </configuration>
             </plugin>
             <!--
               No execution bound to any phase: benchmarks never run as part of `mvn test` or `mvn

src/main/java/org/icroco/pholio/infra/library/LibraryCatalog.java

@@ -45,7 +45,7 @@ public final class LibraryCatalog {
      * runs before there is a Spring context (see its own javadoc), so it cannot go through
      * {@code I18nService}, only around it.
      */
-    private static final String DEFAULT_NAME_KEY = "library.defaultName";
+    private static final String DEFAULT_NAME_KEY = "app.library.defaultName";
 
     private static final Logger log = LoggerFactory.getLogger(LibraryCatalog.class);
 

src/main/java/org/icroco/pholio/ui/shell/AppHeaderBar.java

@@ -211,6 +211,7 @@ public class AppHeaderBar extends HeaderBar implements Disposable {
         ObjectProperty<String> open = preferences.property(LIBRARY_GROUP, LAST_OPENED_KEY, String.class);
         scope.add(available.subscribe(names -> showLibraries(names, open.get())));
         scope.add(open.subscribe(this::select));
+
         return librarySelector;
     }
 

src/main/resources/messages.properties

@@ -2,6 +2,9 @@
 # and for Locale.ENGLISH itself. French lives in messages_fr.properties.
 app.name=Pholio
 app.title=Pholio — Photo library manager
+# LibraryCatalog.defaultLibrary()'s own name, read straight off this bundle rather than through
+# I18nService — see its own javadoc for why (no Spring context exists yet at that point).
+app.library.defaultName=My Photos
 # --- Navigation sidebar ---
 nav.library=Photos
 nav.section.collections=Collections
@@ -22,9 +25,6 @@ nav.maintenance.recognition=People & Pets
 nav.drawer.empty=Nothing here yet
 header.import.tooltip=Import from a card or external drive (coming soon)
 # --- Library folders (Photothèque drawer) ---
-# Read directly off the bundle by LibraryCatalog.defaultLibrary(), not through I18nService — see its own
-# javadoc for why (no Spring context exists yet at that point).
-library.defaultName=My Photos
 library.addFolder.tooltip=Monitor an existing folder.
 library.chooseFolder.dialogTitle=Choose a folder to add
 library.removeFolder.tooltip=Remove this folder

src/main/resources/messages_fr.properties

@@ -1,6 +1,9 @@
 # Reference bundle. Every user-visible string in the application must have a key here.
 app.name=Pholio
 app.title=Pholio — Gestion de photothèque
+# Nom de LibraryCatalog.defaultLibrary(), lu directement dans ce fichier plutôt que via I18nService —
+# voir sa propre javadoc (aucun contexte Spring n'existe encore à ce stade).
+app.library.defaultName=Mes Photos
 # --- Panneau de navigation ---
 nav.library=Photos
 nav.section.collections=Collections
@@ -22,9 +25,6 @@ nav.maintenance.recognition=Personnes et animaux
 nav.drawer.empty=Rien ici pour l'instant
 header.import.tooltip=Importer depuis une carte ou un disque externe (bientôt disponible)
 # --- Dossiers de la photothèque (tiroir) ---
-# Lu directement dans le fichier de traductions par LibraryCatalog.defaultLibrary(), sans passer par
-# I18nService — voir sa propre javadoc (aucun contexte Spring n'existe encore à ce stade).
-library.defaultName=Mes photos
 library.addFolder.tooltip=Surveiller un dossier existant.
 library.chooseFolder.dialogTitle=Choisir un dossier à ajouter
 library.removeFolder.tooltip=Retirer ce dossier